Skip to content

🐛 [Frontend] Fix: duplicated /folders call #6587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Oct 24, 2024
Merged

🐛 [Frontend] Fix: duplicated /folders call #6587

merged 14 commits into from
Oct 24, 2024

Conversation

@odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Oct 23, 2024 •
edited
Loading

What do these changes do?

  • Do not call /folders twice
  • Do not reload cards twice after changing view move (grid/list): the switching is now twice as fast
  • Reduce pagination default limit 20 -> 10

Bug:
Bug

Fixed:
Fix

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Oct 23, 2024
@odeimaiz odeimaiz marked this pull request as ready for review October 24, 2024 09:02
@odeimaiz odeimaiz added this to the MartinKippenberger milestone Oct 24, 2024
@odeimaiz odeimaiz added bug buggy, it does not work as expected a:frontend issue affecting the front-end (area group) labels Oct 24, 2024
@odeimaiz odeimaiz enabled auto-merge (squash) October 24, 2024 09:31
jsaq007
jsaq007 approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@jsaq007 jsaq007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

pcrespov
pcrespov reviewed Oct 24, 2024
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 24, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sanderegg
sanderegg approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@odeimaiz odeimaiz merged commit 6bfab60 into ITISFoundation:master Oct 24, 2024
55 checks passed
@odeimaiz odeimaiz mentioned this pull request Oct 24, 2024
Merged
1 task
This was referenced Oct 29, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pcrespov pcrespov pcrespov left review comments

@sanderegg sanderegg sanderegg approved these changes

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@ignapas ignapas Awaiting requested review from ignapas

@giancarloromeo giancarloromeo Awaiting requested review from giancarloromeo

+1 more reviewer

@jsaq007 jsaq007 jsaq007 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@odeimaiz odeimaiz

Labels

a:frontend issue affecting the front-end (area group) bug buggy, it does not work as expected

Projects

None yet

Milestone

MartinKippenberger

Development

Successfully merging this pull request may close these issues.

5 participants

@odeimaiz @jsaq007 @pcrespov @sanderegg @matusdrobuliak66